Fix #2095, Automatic suppression of flooding events #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 29 potential problems in the proposed changes. Check the Files changed tab for more details.
2 tasks
TheSwarty
approved these changes
Jun 16, 2022
semaldona
reviewed
Jul 27, 2022
| ** \par Limits | ||
| ** This number must be less than or equal to INT_MAX/1000 | ||
| */ | ||
| #define CFE_PLATFORM_EVS_MAX_APP_EVENT_BURST 16 |
There was a problem hiding this comment.
Do we want this feature enabled by default?
semaldona
approved these changes
Jul 27, 2022
skliper
added
the
CCB:Ready
|
@jhnphm - this is planned for CCB on 8/3. Could you review the recent minor changes? Thanks for putting this together! |
jhnphm
suggested changes
Jul 28, 2022
…ent suppression
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2022
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2022
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
CI
Expected behavior changes
Squelches flooding events (configurable)
System(s) tested on
CI
Additional context
Still a work in progress, needs coverage and functional cleanup
Third party code
None, update suggestion from NASA/JSC context.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC
Ping @jhnphm